doc: clarify use of timeout option in vm#23512
Closed
vdeturckheim wants to merge 1 commit intonodejs:masterfrom
vdeturckheim:update_vm_doc
Closed
doc: clarify use of timeout option in vm#23512vdeturckheim wants to merge 1 commit intonodejs:masterfrom vdeturckheim:update_vm_doc
vdeturckheim wants to merge 1 commit intonodejs:masterfrom
vdeturckheim:update_vm_doc
Conversation
vdeturckheim
added
doc
targos
removed
code-and-learn
targos
approved these changes
Oct 12, 2018
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
LGTM. Does it already throw in all cases if the value is not a positive integer?
jasnell
approved these changes
Oct 12, 2018
Member
Author
|
@targos I believe so. I tested 0, 0.1, 10.1 and they all failled |
Contributor
|
Maybe it is worth to replace the |
Member
Author
|
@vsemozhetbyt do you know if we use it somewhere else in the doc? From a js perspective, the argument is of type |
Contributor
|
FWIW, we have it as a hint in Line 8 in b2d8ae0 And we use it in docs: https://github.com/nodejs/node/search?l=Markdown&q=%7Binteger%7D |
Member
Author
|
Make sense! I'll update :) Thanks for pointing it! |
This updates the documentation to clarify how to use `timeout` in the vm module.
Member
Author
|
I am not sure why CI considers the subsystem is missing 🤔 |
Contributor
I saw this on other PRs as well. Probably something wrong with our |
Member
Author
|
Let's restart CI when #23739 (review) is merged then |
trivikr
approved these changes
Oct 19, 2018
Member
Trott
added
the
author ready
Member
|
Landed in 278086a |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 6, 2018
This updates the documentation to clarify how to use `timeout` in the vm module. PR-URL: nodejs#23512 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2018
This updates the documentation to clarify how to use `timeout` in the vm module. PR-URL: #23512 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
This was referenced Nov 16, 2018
codebytere
pushed a commit
that referenced
this pull request
Nov 29, 2018
This updates the documentation to clarify how to use `timeout` in the vm module. PR-URL: #23512 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
This updates the documentation to clarify how to use `timeout` in the vm module. PR-URL: #23512 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
This updates the documentation to clarify how to use `timeout` in the vm module. PR-URL: #23512 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis clarifies the use of the
timeoutoption in thevmmodule. This number always must be a strictly positive integer otherwise it results in aTypeError